feat: Add options to pass task and execution role ARNs #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR similar to #293 |
kg-aws
requested changes
Aug 14, 2025
| @@ -119,6 +121,14 @@ async function run() { | |||
| containerDef.command = command.split(' ') | |||
| } | |||
|
|
|||
| if (taskRoleArn) { | |||
| containerDef.taskRoleArn = taskRoleArn; | |||
There was a problem hiding this comment.
Can we add a regex validation for the arn? Need appropriate unit tests as well for these changes.
| } | ||
|
|
||
| if (executionRoleArn) { | ||
| containerDef.executionRoleArn = executionRoleArn; |
There was a problem hiding this comment.
Can we add a regex validation for the arn? Need appropriate unit tests as well for these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Close #183
Description of changes:
Adds options to set task and execution IAM role ARNs on the rendered task definition. Unfortunately, I noticed #293 exists only after I had already made this, this PR contains also tests for this feature and hopefully makes other tests pass.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.