Skip to content

feat: Add support for maxAttempts to allow retrying after failure #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

pcnoic
Copy link

@pcnoic pcnoic commented May 5, 2025

Context

I know there's already an effort to get this change merged here but it seems like it fell through the cracks after the upgrade to AWS SDK for Javascript (v3) took place.

It appears that a lot of users of this action are encountering rate limits when attempting to deploy task definitions in parallel. This should help mitigate the issue.

Implementation

Allows retries using the updated client specs with maxAttempts and retryMode.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pcnoic pcnoic changed the title Add support for maxAttempts to allow retrying when failing Add support for maxAttempts to allow retrying after failure May 6, 2025
@kg-aws kg-aws self-requested a review May 19, 2025 13:56
@kg-aws kg-aws requested review from omkhegde and kg-aws May 19, 2025 14:15
@kg-aws
Copy link
Contributor

kg-aws commented May 19, 2025

@pcnoic - Thank you the PR. The unit test check is failing blocking the merge. The unit test can be run locally with with npm run test command.

@pcnoic
Copy link
Author

pcnoic commented May 19, 2025

hey @kg-aws - thanks for taking a look. I'll get the unit test fixed.

@kg-aws kg-aws changed the title Add support for maxAttempts to allow retrying after failure feat: Add support for maxAttempts to allow retrying after failure May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants