feat: Add support for maxAttempts to allow retrying after failure
#750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcnoic
changed the title
maxAttempts to allow retrying when failingmaxAttempts to allow retrying after failure
kg-aws
approved these changes
May 19, 2025
omkhegde
approved these changes
May 19, 2025
|
@pcnoic - Thank you the PR. The unit test check is failing blocking the merge. The unit test can be run locally with with |
|
hey @kg-aws - thanks for taking a look. I'll get the unit test fixed. |
kg-aws
changed the title
maxAttempts to allow retrying after failuremaxAttempts to allow retrying after failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
I know there's already an effort to get this change merged here but it seems like it fell through the cracks after the upgrade to AWS SDK for Javascript (v3) took place.
It appears that a lot of users of this action are encountering rate limits when attempting to deploy task definitions in parallel. This should help mitigate the issue.
Implementation
Allows retries using the updated client specs with
maxAttemptsandretryMode.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.