-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vmimage dependency runner #6112
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6112 +/- ##
==========================================
- Coverage 67.16% 67.12% -0.04%
==========================================
Files 203 204 +1
Lines 21973 22035 +62
==========================================
+ Hits 14758 14792 +34
- Misses 7215 7243 +28 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @harvey0100, thank you very much for looking into the vmimage runner. I have added few comments which IMO could simplify the current solution. Please take a look and let me know what do you think.
d1b8ec3
to
a725e50
Compare
Hi @richtja I've made changes towards your comments, the caching section was removed as this is already implemented in the vmimage plugin already. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @harvey0100, thank you very much for the updates. I have added few comments, please let me know what you think about it.
55a8a51
to
12669de
Compare
VM image dependencies in tests * Comprehensive functional tests in `runner_vmimage.py` * Documentation section in dependencies guide * Example test and recipe JSON * Integration with resolver and check systems * Setup.py entry points for plugin discovery Reference: avocado-framework#6043 Signed-off-by: Harvey Lynden <[email protected]>
12669de
to
a3e6528
Compare
VM image dependencies in tests
runner_vmimage.py
Reference: #6043