Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vmimage dependency runner #6112

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

harvey0100
Copy link
Contributor

VM image dependencies in tests

  • Comprehensive functional tests in runner_vmimage.py
  • Documentation section in dependencies guide
  • Example test and recipe JSON
  • Integration with resolver and check systems
  • Setup.py entry points for plugin discovery

Reference: #6043

@harvey0100 harvey0100 requested review from richtja and clebergnu and removed request for richtja January 28, 2025 16:31
@harvey0100 harvey0100 self-assigned this Jan 28, 2025
@harvey0100 harvey0100 added this to the 110 - Codename TBD milestone Jan 28, 2025
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 53.44828% with 27 lines in your changes missing coverage. Please review.

Project coverage is 67.12%. Comparing base (0e6226f) to head (a725e50).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
avocado/plugins/runners/vmimage.py 53.44% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6112      +/-   ##
==========================================
- Coverage   67.16%   67.12%   -0.04%     
==========================================
  Files         203      204       +1     
  Lines       21973    22035      +62     
==========================================
+ Hits        14758    14792      +34     
- Misses       7215     7243      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@richtja richtja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @harvey0100, thank you very much for looking into the vmimage runner. I have added few comments which IMO could simplify the current solution. Please take a look and let me know what do you think.

avocado/plugins/runners/vmimage.py Outdated Show resolved Hide resolved
avocado/plugins/runners/vmimage.py Outdated Show resolved Hide resolved
avocado/plugins/runners/vmimage.py Outdated Show resolved Hide resolved
avocado/plugins/runners/vmimage.py Outdated Show resolved Hide resolved
docs/source/guides/user/chapters/dependencies.rst Outdated Show resolved Hide resolved
examples/tests/dependency_vmimage.py Outdated Show resolved Hide resolved
@harvey0100 harvey0100 force-pushed the vmimageplugin branch 4 times, most recently from d1b8ec3 to a725e50 Compare January 29, 2025 15:52
@harvey0100 harvey0100 requested a review from richtja January 29, 2025 16:15
@harvey0100
Copy link
Contributor Author

Hi @richtja I've made changes towards your comments, the caching section was removed as this is already implemented in the vmimage plugin already.

Copy link
Contributor

@richtja richtja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @harvey0100, thank you very much for the updates. I have added few comments, please let me know what you think about it.

avocado/plugins/runners/vmimage.py Outdated Show resolved Hide resolved
avocado/plugins/runners/vmimage.py Outdated Show resolved Hide resolved
avocado/plugins/runners/vmimage.py Outdated Show resolved Hide resolved
avocado/plugins/runners/vmimage.py Outdated Show resolved Hide resolved
avocado/plugins/runners/vmimage.py Outdated Show resolved Hide resolved
examples/tests/dependency_vmimage.py Outdated Show resolved Hide resolved
examples/tests/dependency_vmimage.py Outdated Show resolved Hide resolved
@harvey0100 harvey0100 force-pushed the vmimageplugin branch 4 times, most recently from 55a8a51 to 12669de Compare February 3, 2025 15:33
 VM image dependencies in tests

 * Comprehensive functional tests in `runner_vmimage.py`
 * Documentation section in dependencies guide
 * Example test and recipe JSON
 * Integration with resolver and check systems
 * Setup.py entry points for plugin discovery

Reference: avocado-framework#6043
Signed-off-by: Harvey Lynden <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Review Requested
Development

Successfully merging this pull request may close these issues.

2 participants