fix 6068:Make the test class dependencies fulfill all the tests. #6089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6089 +/- ##
=========================================
Coverage ? 68.78%
=========================================
Files ? 203
Lines ? 21970
Branches ? 0
=========================================
Hits ? 15112
Misses ? 6858
Partials ? 0 ☔ View full report in Codecov by Sentry. |
The 'type' field is removed from the dependencies_dict (using
pop('type')), which causes the 'type' field to no longer exist in the
dictionary during subsequent operations.
The test updates are necessary because:
1. tests now get executed because of this fix
2. the JSON format needs to be escaped
3. the number of tests and expected passes is really 1 because the
test path given specifies a single test.
Signed-off-by: wangpeng <[email protected]>
Signed-off-by: Cleber Rosa <[email protected]>
clebergnu
force-pushed
the
class_dependencies_all_tests
branch
from
1e1b96b to
9334ad4
Compare
|
@wangp-h FYI, there is some issue with requirements under the Podman spawner: Also, the test is broken because it does not take into account other spawners (it actually uses process in all but podman) still make it believe that it does that them into account. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wangpeng [email protected]