add support for address in memory target #3802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chloerh
reviewed
Dec 4, 2023
| @@ -113,6 +114,11 @@ def __init__(self, virsh_instance=base.base.virsh): | |||
| 'virsh_instance': virsh_instance}) | |||
| accessors.XMLElementBool('readonly', self, parent_xpath='/', | |||
| tag_name='readonly') | |||
| accessors.XMLElementNest('address', self, parent_xpath='/', | |||
| tag_name='address', subclass=Memory().Address, | |||
There was a problem hiding this comment.
Suggested change
| tag_name='address', subclass=Memory().Address, | |
| tag_name='address', subclass=Memory.Address, |
Would this way also work? Therefore we might not need to instantiate Memory class.
There was a problem hiding this comment.
Yes , it works. Thanks haijiao : D
Signed-off-by: nanli <[email protected]>
nanli1
force-pushed
the
add_support_for_address_in_mem_target
branch
from
e6a3eea to
77568d9
Compare
chloerh
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need address attr in Memory.target class
For autotest/tp-libvirt#5293