Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtio_console_guest:update code format to keep compatibility #3801

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

nanliu-r
Copy link
Contributor

@nanliu-r nanliu-r commented Nov 23, 2023

ID: 1427

Drop the 'six' dependency for making the tool used standalone.

@nanliu-r
Copy link
Contributor Author

Test PASS with both RHEL vm(default python version) and Windows vm (Python2).
@luckyh Hi, could you help review this? Thanks

# -*- coding: utf-8 -*-
#!/usr/bin/python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, IMO it has to be the first line for taking effect.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, IMO it has to be the first line for taking effect.

Updated and thanks.

@nanliu-r nanliu-r force-pushed the update_to_python3_format branch 2 times, most recently from 1949622 to 64c8951 Compare November 30, 2023 03:00
@nanliu-r
Copy link
Contributor Author

@luckyh @6-dehan Hi, I updated the commit message this time, please help update this, thanks.

Drop the 'six' dependency for making the tool used standalone.

Signed-off-by: nanliu <[email protected]>
@nanliu-r nanliu-r force-pushed the update_to_python3_format branch from 64c8951 to 2773289 Compare November 30, 2023 07:09
@nanliu-r nanliu-r requested a review from luckyh November 30, 2023 07:11
Copy link
Contributor

@luckyh luckyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luckyh luckyh merged commit 1fb23f1 into avocado-framework:master Nov 30, 2023
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants