Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new nic driver igb on the framework #3799

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

yanglei-rh
Copy link
Contributor

@yanglei-rh yanglei-rh commented Nov 20, 2023

Upstream add an new nic model igb since qemu-8.0.0 which allow testing applications' SR-IOV features on a machine without a specific hardware.In order to cover more nic model,so QE sent a new patch to support this driver.

ID: 1543
Signed-off-by: Lei Yang [email protected]

@yanglei-rh
Copy link
Contributor Author

Hello @PaulYuuu @YongxueHong Could you please help me review this patch? Thanks in advance.

Copy link
Contributor

@PaulYuuu PaulYuuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even igb can be used on other platforms if build from source, but I keep an open mind here. Ack.

@YongxueHong
Copy link
Contributor

Hi @yanglei-rh
Please update the part of the commit message about the internal test requirement info.
We are contributing to the upstream and public projects, and I am sure you are doing that from both the upstream and downstream sides at the same time.
So I suggest that we could update the commit message from the upstream perspective.
Thanks.

@yanglei-rh
Copy link
Contributor Author

Hi @yanglei-rh Please update the part of the commit message about the internal test requirement info. We are contributing to the upstream and public projects, and I am sure you are doing that from both the upstream and downstream sides at the same time. So I suggest that we could update the commit message from the upstream perspective. Thanks.

@YongxueHong Done, please help review it again, thanks a lot.

Upstream add an new nic model igb since qemu-8.0.0 which allow testing
applications' SR-IOV features on a machine without a specific hardware.
In order to cover more nic model,so QE sent a new patch to support this
driver.

Signed-off-by: Lei Yang <[email protected]>
@YongxueHong YongxueHong merged commit 60ef8ea into avocado-framework:master Nov 22, 2023
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants