Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved unused variable warnings #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Resolved unused variable warnings #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/prop_initializer/properties.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
end

property = __prop__initializer_property_class__.new(
name:,

Check failure on line 30 in lib/prop_initializer/properties.rb

View workflow job for this annotation

GitHub Actions / lint 

Lint/Syntax: unexpected token tCOMMA
(Using Ruby 2.7 parser; configure using `TargetRubyVersion` parameter, under `AllCops`)
kind:,
reader:,
writer:,
Expand Down Expand Up @@ -74,6 +74,7 @@
def __generate_prop_initializer_methods__(new_property, buffer = +"")
buffer << "# frozen_string_literal: true\n"
prop_initializer_properties.generate_initializer(buffer)
prop_initializer_properties.generate_properties(buffer)
prop_initializer_properties.generate_to_h(buffer)
new_property.generate_writer_method(buffer) if new_property.writer
new_property.generate_reader_method(buffer) if new_property.reader
Expand Down
7 changes: 6 additions & 1 deletion lib/prop_initializer/properties/schema.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# frozen_string_literal: true

# @api private
class PropInitializer::Properties::Schema

Check failure on line 4 in lib/prop_initializer/properties/schema.rb

View workflow job for this annotation

GitHub Actions / lint 

Lint/Syntax: class definition in method body
(Using Ruby 2.7 parser; configure using `TargetRubyVersion` parameter, under `AllCops`)
include Enumerable

def initialize(properties_index: {}, sorted_properties: [])
Expand Down Expand Up @@ -34,8 +34,8 @@
)
end

def each(&)

Check failure on line 37 in lib/prop_initializer/properties/schema.rb

View workflow job for this annotation

GitHub Actions / lint 

Lint/Syntax: unexpected token tRPAREN
(Using Ruby 2.7 parser; configure using `TargetRubyVersion` parameter, under `AllCops`)
@sorted_properties.each(&)

Check failure on line 38 in lib/prop_initializer/properties/schema.rb

View workflow job for this annotation

GitHub Actions / lint 

Lint/Syntax: unexpected token tRPAREN
(Using Ruby 2.7 parser; configure using `TargetRubyVersion` parameter, under `AllCops`)
end

def size
Expand All @@ -50,6 +50,12 @@
"end\n"
end

def generate_properties(buffer = +"")
buffer << "def properties\n"
buffer << " self.class.prop_initializer_properties.properties_index\n"
buffer << "end\n"
end

def generate_to_h(buffer = +"")
buffer << "def to_h\n" << " {\n"

Expand Down Expand Up @@ -103,7 +109,6 @@
end

def generate_initializer_body(buffer = +"")
buffer << " properties = self.class.prop_initializer_properties.properties_index\n"
generate_initializer_handle_properties(@sorted_properties, buffer)
end

Expand Down
7 changes: 3 additions & 4 deletions lib/prop_initializer/property.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# frozen_string_literal: true

class PropInitializer::Property
ORDER = { :positional => 0, :* => 1, :keyword => 2, :** => 3, :& => 4 }.freeze

Check failure on line 4 in lib/prop_initializer/property.rb

View workflow job for this annotation

GitHub Actions / lint 

Layout/IndentationStyle: Tab detected in indentation.
RUBY_KEYWORDS = %i[alias and begin break case class def do else elsif end ensure false for if in module next nil not or redo rescue retry return self super then true undef unless until when while yield].to_h { |k| [k, "__#{k}__"] }.freeze

Check failure on line 5 in lib/prop_initializer/property.rb

View workflow job for this annotation

GitHub Actions / lint 

Layout/IndentationStyle: Tab detected in indentation.

VISIBILITY_OPTIONS = Set[false, :private, :protected, :public].freeze
KIND_OPTIONS = Set[:positional, :*, :keyword, :**, :&].freeze
Expand Down Expand Up @@ -125,8 +125,7 @@
end

def generate_initializer_handle_property(buffer = +"")
buffer << " # " << @name.name << "\n" <<
" property = properties[:" << @name.name << "]\n"
buffer << " # " << @name.name << "\n"

if @kind == :keyword && ruby_keyword?
generate_initializer_escape_keyword(buffer)
Expand Down Expand Up @@ -156,7 +155,7 @@
def generate_initializer_coerce_property(buffer = +"")
buffer <<
escaped_name <<
"= property.coerce(" <<
"= properties[:" << @name.name << "].coerce(" <<
escaped_name <<
", context: self)\n"
end
Expand All @@ -169,7 +168,7 @@
escaped_name <<
"\n " <<
escaped_name <<
" = property.default_value\n end\n"
" = properties[:" << @name.name << "].default_value\n end\n"
end

def generate_initializer_assign_value(buffer = +"")
Expand Down
Loading