-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure DelayType function gets consistent values of n #125
Conversation
It seems that there's some timing issue with one of the tests:
|
It seems that this test is already disabled for mac:
|
Hi, I sincerely apologize for the delayed response. I've fixed the tests in #99. Please rebase your PR against the main branch so we can proceed with the review. Thank you for your patience and contribution! |
Without this change DelayType function gets n either from 0,1,2,... or from 1,2,3,... depending on the value of Attempts config value. This change unifies the behaviour and makes n always take values from 1,2,3,... Fixes avast#124 Signed-off-by: Piotr Jastrzebski <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #125 +/- ##
=======================================
Coverage 90.86% 90.86%
=======================================
Files 2 2
Lines 230 230
=======================================
Hits 209 209
Misses 17 17
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thank you, for your PR |
Thanks @JaSei ! |
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/avast/retry-go/v4](https://github.com/avast/retry-go) | require | patch | `v4.6.0` -> `v4.6.1` | --- ### Release Notes <details> <summary>avast/retry-go (github.com/avast/retry-go/v4)</summary> ### [`v4.6.1`](https://github.com/avast/retry-go/releases/tag/v4.6.1) [Compare Source](avast/retry-go@4.6.0...4.6.1) #### What's Changed - Update link to docs by [@​ajeetdsouza](https://github.com/ajeetdsouza) in avast/retry-go#100 - fix test for slow windows + add newer golang versions by [@​JaSei](https://github.com/JaSei) in avast/retry-go#126 - Bump github.com/stretchr/testify from 1.9.0 to 1.10.0 by [@​dependabot](https://github.com/dependabot) in avast/retry-go#123 - Make sure DelayType function gets consistent values of n by [@​haaawk](https://github.com/haaawk) in avast/retry-go#125 #### New Contributors - [@​ajeetdsouza](https://github.com/ajeetdsouza) made their first contribution in avast/retry-go#100 - [@​haaawk](https://github.com/haaawk) made their first contribution in avast/retry-go#125 **Full Changelog**: avast/retry-go@4.6.0...v4.6.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "* 0-3 * * *" (UTC), Automerge - "* 0-3 * * *" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yMTIuMCIsInVwZGF0ZWRJblZlciI6IjM5LjIxMi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/519 Reviewed-by: earl-warren <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
Without this change DelayType function gets n either from 0,1,2,... or from 1,2,3,... depending on the value of Attempts config value.
This change unifies the behaviour and makes n always take values from 1,2,3,...
Fixes #124