set state (checkmark) on view menu items to reflect active view

Author: sleifer

PBGitHistoryController.m

@@ -276,6 +276,16 @@ - (IBAction) openSelectedFile:(id)sender
 	[[NSWorkspace sharedWorkspace] openTempFile:name];
 }
 
+- (BOOL)validateMenuItem:(NSMenuItem *)menuItem
+{
+    if ([menuItem action] == @selector(setDetailedView:)) {
+		[menuItem setState:(self.selectedCommitDetailsIndex == kHistoryDetailViewIndex) ? NSOnState : NSOffState];
+    } else if ([menuItem action] == @selector(setTreeView:)) {
+		[menuItem setState:(self.selectedCommitDetailsIndex == kHistoryTreeViewIndex) ? NSOnState : NSOffState];
+    }
+    return YES;
+}
+
 - (IBAction) setDetailedView:(id)sender
 {
 	self.selectedCommitDetailsIndex = kHistoryDetailViewIndex;

PBGitSidebarController.h

@@ -42,4 +42,7 @@
 
 @property(readonly) NSMutableArray *items;
 @property(readonly) NSView *sourceListControlsView;
+@property(readonly) PBGitHistoryController *historyViewController;
+@property(readonly) PBGitCommitController *commitViewController;
+
 @end

PBGitSidebarController.m

@@ -30,6 +30,8 @@ - (void) updateRemoteControls;
 @implementation PBGitSidebarController
 @synthesize items;
 @synthesize sourceListControlsView;
+@synthesize historyViewController;
+@synthesize commitViewController;
 
 - (id)initWithRepository:(PBGitRepository *)theRepository superController:(PBGitWindowController *)controller
 {

PBGitWindowController.m

@@ -43,7 +43,11 @@ - (void)windowWillClose:(NSNotification *)notification
 
 - (BOOL)validateMenuItem:(NSMenuItem *)menuItem
 {
-	if ([menuItem action] == @selector(showCommitView:) || [menuItem action] == @selector(showHistoryView:)) {
+	if ([menuItem action] == @selector(showCommitView:)) {
+		[menuItem setState:(contentController == sidebarController.commitViewController) ? YES : NO];
+		return ![repository isBareRepository];
+	} else if ([menuItem action] == @selector(showHistoryView:)) {
+		[menuItem setState:(contentController != sidebarController.commitViewController) ? YES : NO];
 		return ![repository isBareRepository];
 	}
 	return YES;