explicitly disable external diff so we get the results we need even if the user has an external diff configured

Author: sleifer

PBDiffWindowController.m

@@ -34,7 +34,7 @@ + (void) showDiffWindowWithFiles:(NSArray *)filePaths fromCommit:(PBGitCommit *)
 		diffCommit = [startCommit.repository headCommit];
 
 	NSString *commitSelector = [NSString stringWithFormat:@"%@..%@", [startCommit realSha], [diffCommit realSha]];
-	NSMutableArray *arguments = [NSMutableArray arrayWithObjects:@"diff", commitSelector, nil];
+	NSMutableArray *arguments = [NSMutableArray arrayWithObjects:@"diff", @"--no-ext-diff", commitSelector, nil];
 
 	if (![PBGitDefaults showWhitespaceDifferences])
 		[arguments insertObject:@"-w" atIndex:1];

gitx.m

@@ -124,9 +124,9 @@ void handleSTDINDiff()
 	}
 }
 
-void handleDiffWithArguments(NSURL *repositoryURL, NSMutableArray *arguments)
+void handleDiffWithArguments(NSURL *repositoryURL, NSArray *arguments)
 {
-	[arguments insertObject:@"diff" atIndex:0];
+	arguments = [[NSArray arrayWithObjects:@"diff", @"--no-ext-diff", nil] arrayByAddingObjectsFromArray:arguments];
 
 	int retValue = 1;
 	NSString *diffOutput = [PBEasyPipe outputForCommand:[PBGitBinary path] withArgs:arguments inDir:[repositoryURL path] retValue:&retValue];