Fix issues reported by Xcode's build and analyze

brotherbard · brotherbard · commit 9e3e2725c0f3 · 2010-08-22T07:50:42.000-06:00
Using the LLVM GCC 4.2 compiler.
diff --git a/DBPrefsWindowController.m b/DBPrefsWindowController.m
@@ -370,7 +370,7 @@ - (void)animationDidEnd:(NSAnimation *)animation
 	NSEnumerator *subviewsEnum = [[contentSubview subviews] reverseObjectEnumerator];
 
 		// This is our visible view. Just get past it.
-	subview = [subviewsEnum nextObject];
+	[subviewsEnum nextObject];
 
 		// Remove everything else. There should be just one, but
 		// if the user does a lot of fast clicking, we might have
diff --git a/PBGitRevisionCell.m b/PBGitRevisionCell.m
@@ -208,7 +208,7 @@ - (void) drawRefsInRect: (NSRect *)refRect
 {
 	[[NSColor blackColor] setStroke];
 
-	NSRect lastRect;
+	NSRect lastRect = NSMakeRect(0, 0, 0, 0);
 	int index = 0;
 	for (NSValue *rectValue in [self rectsForRefsinRect:*refRect])
 	{

Original file line number	Diff line number	Diff line change
`@@ -208,7 +208,7 @@ - (void) drawRefsInRect: (NSRect *)refRect`
`208`	`208`	`{`
`209`	`209`	`[[NSColor blackColor] setStroke];`
`210`	`210`
`211`		`- NSRect lastRect;`
	`211`	`+ NSRect lastRect = NSMakeRect(0, 0, 0, 0);`
`212`	`212`	`int index = 0;`
`213`	`213`	`for (NSValue rectValue in [self rectsForRefsinRect:refRect])`
`214`	`214`	`{`