Fixing compiler warnings.

Author: Jan Weiß

PBEasyPipe.m

@@ -120,7 +120,7 @@ + (NSString*) outputForCommand: (NSString*) cmd withArgs: (NSArray*) args  inDir
 		data = [handle readDataToEndOfFile];
 	}
 	@catch (NSException * e) {
-		NSLog(@"Got a bad file descriptor in %s!", _cmd);
+		NSLog(@"Got a bad file descriptor in %@!", NSStringFromSelector(_cmd));
 		if ([NSThread currentThread] != [NSThread mainThread])
 			[task waitUntilExit];
 

PBGitHistoryController.m

@@ -676,7 +676,7 @@ - (NSInteger)numberOfPreviewItemsInPreviewPanel:(id)panel
 	PBGitTree *treeItem = (PBGitTree *)[[treeController selectedObjects] objectAtIndex:index];
 	NSURL *previewURL = [NSURL fileURLWithPath:[treeItem tmpFileNameForContents]];
 
-    return (<QLPreviewItem>)previewURL;
+    return (id <QLPreviewItem>)previewURL;
 }
 
 #pragma mark <QLPreviewPanelDelegate>

PBGitRepository.m

@@ -232,7 +232,7 @@ - (void) addRef: (PBGitRef *) ref fromParameters: (NSArray *) components
 		sha = [PBGitSHA shaWithString:[components objectAtIndex:2]];
 
 	NSMutableArray* curRefs;
-	if (curRefs = [refs objectForKey:sha])
+	if ( (curRefs = [refs objectForKey:sha]) != nil )
 		[curRefs addObject:ref];
 	else
 		[refs setObject:[NSMutableArray arrayWithObject:ref] forKey:sha];

PBGitRevList.mm

@@ -165,7 +165,7 @@ - (void) walkRevisionListWithSpecifier:(PBGitRevSpecifier*)rev
 		if (parentString.size() != 0)
 		{
 			if (((parentString.size() + 1) % 41) != 0) {
-				NSLog(@"invalid parents: %i", parentString.size());
+				NSLog(@"invalid parents: %zu", parentString.size());
 				continue;
 			}
 			int nParents = (parentString.size() + 1) / 41;
@@ -225,7 +225,7 @@ - (void) walkRevisionListWithSpecifier:(PBGitRevSpecifier*)rev
 		[self performSelectorOnMainThread:@selector(finishedParsing) withObject:nil waitUntilDone:NO];
 	}
 	else {
-		NSLog(@"[%@ %s] thread has been canceled", [self class], _cmd);
+		NSLog(@"[%@ %s] thread has been canceled", [self class], NSStringFromSelector(_cmd));
 	}
 
 	[task terminate];

PBGitSidebarController.m

@@ -125,15 +125,15 @@ - (void) selectCurrentBranch
 
 	PBSourceViewItem *item = nil;
 	for (PBSourceViewItem *it in items)
-		if (item = [it findRev:rev])
+		if ( (item = [it findRev:rev]) != nil )
 			break;
 
 	if (!item) {
 		[self addRevSpec:rev];
 		// Try to find the just added item again.
 		// TODO: refactor with above.
 		for (PBSourceViewItem *it in items)
-			if (item = [it findRev:rev])
+			if ( (item = [it findRev:rev]) != nil )
 				break;
 	}
 
@@ -147,7 +147,7 @@ - (PBSourceViewItem *) itemForRev:(PBGitRevSpecifier *)rev
 {
 	PBSourceViewItem *foundItem = nil;
 	for (PBSourceViewItem *item in items)
-		if (foundItem = [item findRev:rev])
+		if ( (foundItem = [item findRev:rev]) != nil )
 			return foundItem;
 	return nil;
 }

PBGitTree.m

@@ -65,10 +65,12 @@ - (BOOL) isLocallyCached
 
 - (BOOL)hasBinaryHeader:(NSString*)contents
 {
-	if(!contents)
+	if (!contents)
 		return NO;
 
-	return [contents rangeOfString:@"\0" options:0 range:NSMakeRange(0, ([contents length] >= 8000) ? 7999 : [contents length])].location != NSNotFound;
+	return [contents rangeOfString:@"\0"
+						   options:0
+							 range:NSMakeRange(0, ([contents length] >= 8000) ? 7999 : [contents length])].location != NSNotFound;
 }
 
 - (BOOL)hasBinaryAttributes

PBRemoteProgressSheet.m

@@ -130,7 +130,7 @@ - (void) taskCompleted:(NSNotification *)notification
 - (void) checkTask:(NSTimer *)timer
 {
 	if (![gitTask isRunning]) {
-		NSLog(@"[%@ %s] gitTask terminated without notification", [self class], _cmd);
+		NSLog(@"[%@ %@] gitTask terminated without notification", [self class], NSStringFromSelector(_cmd));
 		[self taskCompleted:nil];
 	}
 }

PBSourceViewItem.m

@@ -103,7 +103,7 @@ - (PBSourceViewItem *)findRev:(PBGitRevSpecifier *)rev
 
 	PBSourceViewItem *item = nil;
 	for (PBSourceViewItem *child in children)
-		if (item = [child findRev:rev])
+		if ( (item = [child findRev:rev]) != nil )
 			return item;
 
 	return nil;

gitx.m

@@ -33,7 +33,7 @@
 	// Now attempt to connect, allowing the app time to startup
 	int attempt;
 	for (attempt = 0; proxy == nil && attempt < 50; ++attempt) {
-		if (proxy = connect())
+		if ( (proxy = connect()) != nil )
 			return proxy;
 
 		usleep(15000);