fix: Add compressed proof to input in execute batch #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prabhat1308
force-pushed
the
pv/recursive_proof_task
branch
from
e38f3ab to
034c03f
Compare
vibhurajeev
reviewed
Dec 12, 2024
nexus/host/src/main.rs
Outdated
|
|
||
| // let compressed_proof = proof.compress(); | ||
| // let final_proof = compressed_proof.expect("proof compression failed"); | ||
| computed_proof = Some(proof); |
There was a problem hiding this comment.
We need some work here. On restarts this will be a problem, as we only store the proof in memory.
There was a problem hiding this comment.
Ideally the proof should be stored in rocksdb that can be queried, even on restarts.
Prabhat1308
force-pushed
the
pv/recursive_proof_task
branch
from
73fbd31 to
3e00fa4
Compare
|
The CI test all run infinitely at the line 428 in lib.rs in Seems like the node_db lock is not being freed in the previous calls to it. |
pushed the fix for it |
Prabhat1308
force-pushed
the
pv/recursive_proof_task
branch
from
1a3dd94 to
ead3d60
Compare
Prabhat1308
force-pushed
the
pv/recursive_proof_task
branch
from
ead3d60 to
76078b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.