Skip to content

Commit

Permalink
Fix data root computation on blob transactions. (#370)
Browse files Browse the repository at this point in the history
  • Loading branch information
@0xSasaPrsic
0xSasaPrsic authored Jan 16, 2024
1 parent 8c101e9 commit e976c56
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pallets/system/src/submitted_data.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ where
.into_iter()
.filter(|v| !v.is_empty())
.map(|leaf| {
if call_type == SubTrie::Right {
if call_type == SubTrie::Left {
leaf
} else {
keccak_256(leaf.as_slice()).to_vec()
Expand Down

2 comments on commit e976c56

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: e976c56 Previous: 33f7951 Ratio
commitment_builder/32 4193356954 ns/iter (± 43734366) 4325417137 ns/iter (± 81695432) 0.97
commitment_builder/64 4131397165 ns/iter (± 30882660) 4343451680 ns/iter (± 92231152) 0.95
commitment_builder/128 4519766675 ns/iter (± 83361255) 4647446215 ns/iter (± 137494514) 0.97
commitment_builder/256 2214353639 ns/iter (± 33937340) 2367397557 ns/iter (± 42776582) 0.94

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: e976c56 Previous: 909af7f Ratio
commitment_builder_32 Instructions 43493408992 ops (± 0) 43503093041 ops (± 0) 1.00
commitment_builder_32 L1 Accesses 53524916407 ops (± 0) 53514815042 ops (± 0) 1.00
commitment_builder_32 L2 Accesses 685908 ops (± 0) 700403 ops (± 0) 0.98
commitment_builder_32 RAM Accesses 92077 ops (± 0) 89904 ops (± 0) 1.02
commitment_builder_32 Estimated Cycles 53531568642 ops (± 0) 53521463697 ops (± 0) 1.00
commitment_builder_64 Instructions 41962729645 ops (± 0) 41972869826 ops (± 0) 1.00
commitment_builder_64 L1 Accesses 51417139214 ops (± 0) 51407870438 ops (± 0) 1.00
commitment_builder_64 L2 Accesses 813913 ops (± 0) 893120 ops (± 0) 0.91
commitment_builder_64 RAM Accesses 191170 ops (± 0) 191298 ops (± 0) 1.00
commitment_builder_64 Estimated Cycles 51427899729 ops (± 0) 51419031468 ops (± 0) 1.00
commitment_builder_128 Instructions 54192518402 ops (± 0) 54204175550 ops (± 0) 1.00
commitment_builder_128 L1 Accesses 68310692154 ops (± 0) 68301951624 ops (± 0) 1.00
commitment_builder_128 L2 Accesses 1262991 ops (± 0) 1258510 ops (± 0) 1.00
commitment_builder_128 RAM Accesses 258060 ops (± 0) 242507 ops (± 0) 1.06
commitment_builder_128 Estimated Cycles 68326039209 ops (± 0) 68316731919 ops (± 0) 1.00
commitment_builder_256 Instructions 31751800079 ops (± 0) 31758548180 ops (± 0) 1.00
commitment_builder_256 L1 Accesses 40835647525 ops (± 0) 40833274463 ops (± 0) 1.00
commitment_builder_256 L2 Accesses 6763198 ops (± 0) 6788005 ops (± 0) 1.00
commitment_builder_256 RAM Accesses 253963 ops (± 0) 239352 ops (± 0) 1.06
commitment_builder_256 Estimated Cycles 40878352220 ops (± 0) 40875591808 ops (± 0) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.