Skip to content

Conversation

@alarso16
Copy link
Contributor

@alarso16 alarso16 commented Nov 14, 2025

Why this should be merged

There was an undocumented breaking change in Firewood, and the database sometimes does not close as expected. To avoid the core issue (file closure occurring in the background), the file can be copied to create a new database instance.

How this works

Cherry-picks ava-labs/coreth#1376

How this was tested

Fixed it on coreth!

Need to be documented?

No

Need to update RELEASES.md?

No

@alarso16 alarso16 self-assigned this Nov 14, 2025
@alarso16 alarso16 added flaky-test Test failing occasionally coreth sync labels Nov 14, 2025
@alarso16 alarso16 marked this pull request as ready for review November 14, 2025 20:01
@alarso16 alarso16 requested a review from a team as a code owner November 14, 2025 20:01
@ceyonur ceyonur added this pull request to the merge queue Nov 15, 2025
Merged via the queue into master with commit 74e4756 Nov 15, 2025
13 checks passed
@ceyonur ceyonur deleted the alarso16/core-flake branch November 15, 2025 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

coreth sync flaky-test Test failing occasionally

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants