sync: coreth PR #1363,1384: test: Fix rpc flakes #1833
+44
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Austin Larson <[email protected]> Co-authored-by: Stephen Buttolph <[email protected]>
JonathanOppenheimer
changed the title
JonathanOppenheimer
approved these changes
Nov 4, 2025
powerslider
reviewed
Nov 14, 2025
| opts = append(opts, WithWebsocketMessageSizeLimit(*limit)) | ||
| if *limit > 0 { | ||
| expLimit = *limit // 0 means infinite | ||
| for _, tt := range []struct { |
Contributor
There was a problem hiding this comment.
nit: please extract the anonymous struct as a variable called tests and use named fields when creating instances of it. Let's stick to one way of declaring parameters for table driven tests. avalanchego also insist on this specific way of declaring them.
Contributor
Author
There was a problem hiding this comment.
I don't want to change geth code
powerslider
reviewed
Nov 14, 2025
| testLimit(ptr(wsDefaultReadLimit + 1024)) | ||
| var res string | ||
| err = client.Call(&res, "test_repeat", "A", tt.size) | ||
| if tt.err && err == nil { |
Contributor
There was a problem hiding this comment.
why not use require from testify here and the lines below?
Contributor
There was a problem hiding this comment.
because these are tests from geth packages?
ceyonur
reviewed
Nov 14, 2025
rpc/main_test.go
Outdated
Comment on lines
38
to
48
| customtypes.Register() | ||
|
|
||
| // Since there are so many flaky tests in the RPC package, we run the tests | ||
| // multiple times to try to get a passing run. | ||
| var code int | ||
| for range 5 { | ||
| code = m.Run() | ||
| if code == 0 { | ||
| break | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Why are we doing this if we skip flaky ones?
Contributor
Author
There was a problem hiding this comment.
That's a good point, I'll remove it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This cherry-picks ava-labs/coreth#1363 and ava-labs/coreth#1384, since they are very similar. They can be reviewed by commit if one prefers, but the diff for the second PR is extremely minimal (comments and
t.Skip)How this works
Same as in coreth
How this was tested
UT
Need to be documented?
No
Need to update RELEASES.md?
No