e2e: add client tests #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Batschelet <[email protected]>
Signed-off-by: Sam Batschelet <[email protected]>
Signed-off-by: Sam Batschelet <[email protected]>
hexfusion
force-pushed
the
cli-e2e
branch
3 times, most recently
from
afcd780 to
afcd401
Compare
Signed-off-by: Sam Batschelet <[email protected]>
hexfusion
commented
Nov 26, 2022
Signed-off-by: Sam Batschelet <[email protected]>
Signed-off-by: Sam Batschelet <[email protected]>
|
tungstenite failure now resolved snapview/tungstenite-rs#321 |
Signed-off-by: Sam Batschelet <[email protected]>
hexfusion
commented
Nov 28, 2022
exdx
approved these changes
Nov 28, 2022
Signed-off-by: Sam Batschelet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic e2e testing for the api client to ensure no regressions in logic. More robust tests will be added once #85 merges.
Signed-off-by: Sam Batschelet [email protected]