refactor: remove default 1-minute timeout on Database.Close() and set 1-sec in tests
#1458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et 1-sec in tests
alarso16
reviewed
Nov 14, 2025
|
|
||
| // TestCloseWithShortTimeout verifies that Database.Close returns | ||
| // ErrActiveKeepAliveHandles when the context times out before handles are dropped. | ||
| func TestCloseWithShortTimeout(t *testing.T) { |
Contributor
There was a problem hiding this comment.
This test no longer means anything, since we only rely on a timeout supplied by the user
rkuris
approved these changes
Nov 14, 2025
Contributor
Author
|
Thanks for picking this up @alarso16. Feel free to merge when you're ready, or DM me if I need to do it since I opened the PR. |
demosdemon
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1457