fix: (bitcoin module) Fix to grab bitcoin module properly #162
+14
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frichards
added
the
DO NOT MERGE
frichards
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://ava-labs.atlassian.net/browse/CP-9900
Talking to Michal about this.
Issue:
When core web calls handlers from bitcoin vm module while connected to extension, it throws an error.
It seems like bitcoin module is not found in DAppRequestHandlerMiddleware when moduleManager.loadModule is called.
Since the context.network is set properly using the same scope, the bitcoin module shouild be found.
Changes
Instead of scope, if bitcoin, passing the chain ID. (The logic is borrowed from NetworkService.getNetwork to mimic setting context.network)
Testing
Screenshots:
Checklist for the author
Tick each of them when done or if not applicable.