Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP-9960] appcheck improvements #159

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

bferenc
Copy link
Contributor

@bferenc bferenc commented Feb 25, 2025

Description

Prevent firebase initialization in unsupported browsers.

Changes

  • increases token fetch timeout to match the token's expiry
  • introduces timeouts for registration and verification
  • ignores push service registration errors
  • adds a browser type check to FirebaseService

Testing

The extension should still generate appcheck tokens for Chrome and Brave, but not for other browsers.

Screenshots:

Chrome

image

Brave

image

Edge

image

Checklist for the author

Tick each of them when done or if not applicable.

  • I've covered new/modified business logic with Jest test cases.
  • I've tested the changes myself before sending it to code review and QA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant