wait until local p-chain has caught up with the p-chain height of inner VM blocks #3905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for !vm.isLocalPlatformChainInSync() { | ||
| time.Sleep(pChainPostBootstrapSyncPollInterval) | ||
| } | ||
| scheduler.Dispatch(time.Now()) |
There was a problem hiding this comment.
By deferring the call to Dispatch the scheduler is going to block upon calls to scheduler.SetBuildBlockTime. However, scheduler.SetBuildBlockTime is called with the context lock held in SetPreference.
I think that can cause a deadlock if we are unlucky enough for the P-chain to have caught back up before SetPreference is called but without isLocalPlatformChainInSync having returned true.
yacovm
force-pushed
the
platformVMDispatch
branch
7 times, most recently
from
625b6dc to
d302519
Compare
…er VM blocks Signed-off-by: Yacov Manevich <[email protected]>
yacovm
force-pushed
the
platformVMDispatch
branch
from
d302519 to
95f020b
Compare
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
|
This PR is being closed due to no activity. Please re-open if this needs to be prioritized. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
How this works
How this was tested
Need to be documented in RELEASES.md?