use atomicvm version for coreth #3900
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avalanchego into coreth-atomic-refactor
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
There was a problem hiding this comment.
Pull Request Overview
Bumps the Coreth dependency to the AtomicVM release and switches VM initialization to use Coreth’s factory plugin.
- Update Coreth module version in go.mod to v0.15.3-0.20250707183503-ecbf4f324f17
- Change import and VMManager registration to use
coreth/plugin/factory.Factory
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| node/node.go | Replaced coreth/plugin/evm import with coreth/plugin/factory and updated factory call |
| go.mod | Bumped github.com/ava-labs/coreth to the AtomicVM version |
|
This PR was essentially included in #3999. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Bumps coreth to atomicvm version in ava-labs/coreth#1031 (now in maser)
How this works
Bumps coreth and uses plugin/factory pkg to initialize the factory (formerly in plugin/evm)
How this was tested
e2e tests
bootstrap fuji
Need to be documented in RELEASES.md?
No