refactor: export PeerSample #3745
Merged
+8
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronbuchwald
approved these changes
Feb 25, 2025
yacovm
approved these changes
Feb 25, 2025
joshua-kim
reviewed
Feb 26, 2025
network/p2p/network.go
Outdated
| @@ -197,11 +197,12 @@ func (p *Peers) Sample(limit int) []ids.NodeID { | |||
| return p.set.Sample(limit) | |||
| } | |||
|
|
|||
| type peerSampler struct { | |||
| // PeerSampler implements NodeSampler | |||
| type PeerSampler struct { | |||
| peers *Peers | |||
There was a problem hiding this comment.
Doesn't this need to be exported too?
There was a problem hiding this comment.
It doesn't having PeerSampler exported and Sample is enough.
There was a problem hiding this comment.
Agreed to export peers instead of adding constructor privately.
joshua-kim
approved these changes
Feb 26, 2025
- Export PeerSample type - Add documentation - Export peers field from PeerSampler
Elvis339
force-pushed
the
add-public-nodesampler-api
branch
from
68781fb to
4c1da47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Closes #3734
Improves modularity by refactoring and exporting
PeerSample, ensuring reuse.How this works
The
PeerSamplecomponent has been refactored and exported, making it easier to import and use elsewhere.How this was tested
Need to be documented in RELEASES.md?