[tmpnet] Add check for collection of logs and metrics to custom github action #3740
+346
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maru-ava
force-pushed
the
tmpnet-check-metrics-collection
branch
3 times, most recently
from
ab202c2 to
fd27d90
Compare
5 tasks
maru-ava
force-pushed
the
tmpnet-check-metrics-collection
branch
3 times, most recently
from
3ec85e1 to
2e6404a
Compare
maru-ava
force-pushed
the
tmpnet-managed-collectors
branch
from
91b64a7 to
4dce5a1
Compare
maru-ava
force-pushed
the
tmpnet-check-metrics-collection
branch
5 times, most recently
from
453b332 to
e4243fc
Compare
maru-ava
changed the title
aaronbuchwald
approved these changes
Feb 24, 2025
| @@ -388,6 +388,8 @@ github.com/jessevdk/go-flags v0.0.0-20141203071132-1679536dcc89/go.mod h1:4FA24M | |||
| github.com/jessevdk/go-flags v1.4.0/go.mod h1:4FA24M0QyGHXBuZZK/XkWh8h0e1EYbRYJSGM75WSRxI= | |||
| github.com/josharian/intern v1.0.0 h1:vlS4z54oSdjm0bgjRigI+G1HpF+tI+9rE5LLzOg8HmY= | |||
| github.com/josharian/intern v1.0.0/go.mod h1:5DoeVV0s6jJacbCEi61lwdGj/aVlrQvzHFFd8Hwg//Y= | |||
| github.com/jpillora/backoff v1.0.0 h1:uvFg412JmmHBHw7iwprIxkPMI+sGQ4kzOWsMeHnm2EA= | |||
There was a problem hiding this comment.
Why is go.sum changed with no corresponding change?
There was a problem hiding this comment.
I think it's because of my use of the prometheus client. I didn't add any deps but the go mod job failed and this was the result of running 'go mod tidy'.
maru-ava
force-pushed
the
tmpnet-managed-collectors
branch
from
4dce5a1 to
1a5222c
Compare
maru-ava
force-pushed
the
tmpnet-check-metrics-collection
branch
2 times, most recently
from
424f7dc to
198b68f
Compare
maru-ava
force-pushed
the
tmpnet-check-metrics-collection
branch
from
198b68f to
049efef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Adds checks to the run-monitored-tmpnet-cmd custom github action that verifies that logs were collected to loki and metrics were collected to prometheus for the job. A failing check will fail the job, ensuring that collection of logs and metrics doesn't silently fail to occur. This should also make reuse easier since any configuration issue will be more obvious.
How this works
tmnetctl check-metricsto enable querying prometheus for metrics labeled for a github runtmnetctl check-logsto enable querying loki for logs labeled for a github runHow this was tested
tmpnetctl check-metricspasses for a network UUID for which metrics existtmpnetctl check-metricsfails for a non-existent network UUIDNeed to be documented in RELEASES.md?
N/A
TODO