Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Simplify tmpnet monitoring action #3736

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

maru-ava
Copy link
Contributor

@maru-ava maru-ava commented Feb 21, 2025

Why this should be merged

Incorporates the following into the action to simplify usage:

  • Configure network shutdown delay to ensure a final metrics scrape
  • Save tmpnet dir as a github artifact
  • Encapsulate nix installation into a new custom action

How this works

  • Enables network shutdown delay with TMPNET_DELAY_NETWORK_SHUTDOWN env var to enable configuration via the action rather than in the caller and configures action to use it

How this was tested

CI:

  • Checked that one of the modified jobs reports metrics and logs
  • Checked that artifacts are still created for the modified jobs

Need to be documented in RELEASES.md?

N/A

@maru-ava maru-ava self-assigned this Feb 21, 2025
@maru-ava maru-ava added the ci This focuses on changes to the CI process label Feb 21, 2025
@maru-ava maru-ava force-pushed the tmpnet-simplify-monitoring-action branch from 71d46bf to 757b07a Compare February 21, 2025 17:19
@maru-ava maru-ava force-pushed the tmpnet-simplify-monitoring-action branch 3 times, most recently from d19e044 to 0c9fe11 Compare February 22, 2025 15:03
@maru-ava maru-ava force-pushed the tmpnet-simplify-monitoring-action branch 2 times, most recently from b1e800e to 260259e Compare February 24, 2025 13:08
Incorporate the following into the action to simplify usage:
- Configure network shutdown delay to ensure a final metrics scrape
- Save tmpnet dir as a github artifact
@maru-ava maru-ava force-pushed the tmpnet-simplify-monitoring-action branch from 260259e to af785f9 Compare February 24, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci This focuses on changes to the CI process
Projects
Status: In Review 👀
Development

Successfully merging this pull request may close these issues.

2 participants