[testing] Add av command to simplify cross-repo tool maintenance
#3619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, ginkgo was installed with an explicit version which made it easy for the ginkgo command and the test code to be using different versions. Using `go run` without a tag ensures that the go.mod version of ginkgo is always used for the command.
- not sure it is ideal to have to wrap commands
- how does `go tool` do it?
- maybe stick to installing and using the installed version
- `go run` makes sense for local commands, but why for ones in
different repos?
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
In anticipation of rewriting shell scripts intended for reuse (in VM repos like subnet-evm and hypersdk) to golang, add a unified entrypoint to simplify usage.
How this works
tests/av/cmdwith support for running ginkgoHow this was tested
CI validating usage of ginkgo
Need to be documented in RELEASES.md?
N/A