-
Notifications
You must be signed in to change notification settings - Fork 255
Add minimum transfer amount to transporting to different chain through XDM #3545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jim-counter will likely have a stronger opinion here, but 10 seems to high. On mainnet it will take small farmers a significant amount of time to earn 10 AI3, leaving them unable to transfer from Consensus. I don't know what the value should be, but 1 AI3 seems more reasonable. When transferring isn't incentivized, there is little incentive for users to burn fees transferring small amounts of actual (versus test) AI3. |
1 AI3 is reasonable to me but having such a min transfer is does avoid channel blockages if some does try to fill up the channel. I dont mind not including this yet but would be nice to have this than later |
Agree with 1 AI3 as a starting position. We are upping the limit from the current 1 Shannon and can always tune this based on real-world usage observation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes LGTM, please update MinimumTransfer
if we decided to go with 1 AI3
0c34710
to
d3d4afd
Compare
Add minimum transfer amount to transporting to different chain through XDM
Looks like there is issue with latest main. Will look into it later and push a fix |
d3d4afd
to
1012194
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Currently we allow as little as 1 unit to transfer from one chain to another through XDM. As seen in taurus, anyone scripter with even small amount of balance can occupy a full channel and opening a new channel is costly.
With a minimum transfer, this could be alleviated and allow fair and actual usage of XDM.
Currently set it as 10 AI3 but this can be played around as well.
Thoughts on the 10 Ai3 being less or more @jfrank-summit @jim-counter ?
Code contributor checklist: