Skip to content

Add minimum transfer amount to transporting to different chain through XDM #3545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

vedhavyas
Copy link
Contributor

Currently we allow as little as 1 unit to transfer from one chain to another through XDM. As seen in taurus, anyone scripter with even small amount of balance can occupy a full channel and opening a new channel is costly.

With a minimum transfer, this could be alleviated and allow fair and actual usage of XDM.
Currently set it as 10 AI3 but this can be played around as well.

Thoughts on the 10 Ai3 being less or more @jfrank-summit @jim-counter ?

Code contributor checklist:

@jfrank-summit
Copy link
Member

@jim-counter will likely have a stronger opinion here, but 10 seems to high. On mainnet it will take small farmers a significant amount of time to earn 10 AI3, leaving them unable to transfer from Consensus. I don't know what the value should be, but 1 AI3 seems more reasonable. When transferring isn't incentivized, there is little incentive for users to burn fees transferring small amounts of actual (versus test) AI3.

@vedhavyas
Copy link
Contributor Author

1 AI3 is reasonable to me but having such a min transfer is does avoid channel blockages if some does try to fill up the channel.

I dont mind not including this yet but would be nice to have this than later

@jim-counter
Copy link
Member

Agree with 1 AI3 as a starting position. We are upping the limit from the current 1 Shannon and can always tune this based on real-world usage observation.

Copy link
Member

@NingLin-P NingLin-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM, please update MinimumTransfer if we decided to go with 1 AI3

@vedhavyas vedhavyas requested a review from NingLin-P May 22, 2025 13:45
@vedhavyas vedhavyas enabled auto-merge May 22, 2025 13:45
@vedhavyas vedhavyas force-pushed the min_transfer_amount branch from 0c34710 to d3d4afd Compare May 22, 2025 14:12
NingLin-P
NingLin-P previously approved these changes May 22, 2025
@vedhavyas vedhavyas added this pull request to the merge queue May 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 23, 2025
@vedhavyas vedhavyas added this pull request to the merge queue May 23, 2025
github-merge-queue bot pushed a commit that referenced this pull request May 23, 2025
Add minimum transfer amount to transporting to different chain through XDM
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 23, 2025
@vedhavyas vedhavyas added this pull request to the merge queue May 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 23, 2025
@NingLin-P NingLin-P added this pull request to the merge queue May 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 23, 2025
@vedhavyas
Copy link
Contributor Author

Looks like there is issue with latest main. Will look into it later and push a fix

Copy link
Member

@jfrank-summit jfrank-summit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vedhavyas vedhavyas added this pull request to the merge queue May 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 27, 2025
@vedhavyas vedhavyas added this pull request to the merge queue May 27, 2025
Merged via the queue into main with commit 085ec66 May 27, 2025
19 of 21 checks passed
@vedhavyas vedhavyas deleted the min_transfer_amount branch May 27, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants