Rename crate::exid::ExId to crate::obj_id::ObjId

[teohhanhui]

No description provided.

[alexjg]

Now, the interesting question is whether this has any compatibility effects. It seems like it should definitely not, because the exported name and type have not changed, but I am cautious. @teohhanhui did you encounter anywhere when you wrote code against this library that had to use ExId rather than ObjId?

[teohhanhui]

Now, the interesting question is whether this has any compatibility effects. It seems like it should definitely not, because the exported name and type have not changed, but I am cautious.

If we used type alias it'd have compatibility concerns: https://predr.ag/blog/re-exporting-enum-with-type-alias-breaking-change-not-major/

But we didn't. There are no compatibility concerns that I'm aware of.

@teohhanhui did you encounter anywhere when you wrote code against this library that had to use ExId rather than ObjId?

No.

[teohhanhui]

This change doesn't fix everything. Wherever ExId is still present in impl block header or function / method signature...

[alexjg]

This change doesn't fix everything. Wherever ExId is still present in impl block header or function / method signature...

Can you elaborate?

[teohhanhui]

e.g.

automerge/rust/automerge/src/autocommit.rs

Line 574 in 9400e19

pub fn hash_for_opid(&self, opid: &ExId) -> Option<ChangeHash> {

results in

but it links correctly to automerge::ObjId (same as before).

So what this PR achieves is pretty minimal. I've limited myself to only getting rid of any mention of ExId from the automerge::ObjId page itself, and the one case of [`ExId`] in the rustdoc / doc comment that I could find.

[teohhanhui]

Looks like that will be fixed soon: rust-lang/rust#113374

[alexjg]

Hmm, do we need to make this change then?

[teohhanhui]

In the linked PR, I don't see any tests for impl block header.

[teohhanhui]

Looks like that's rust-lang/rust#41072

[alexjg]

I'm inclined to think that this is a rustdoc bug and we should just wait for it to be fixed as even with these changes we end up with ExId leaking out, wdyt?