-
Notifications
You must be signed in to change notification settings - Fork 231
feat: add error code constants for WebAuth and CredentialsManager #1340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
|
This is good 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, please run yarn lint and fix the linting issues.
|
I've fixed my PR |
|
Hi @hugoecken can you please verify your commits |
07785cb to
0d5ee78
Compare
|
Hi @subhankarmaiti, its the first time I have to sign commits. Does it looks ok to you ? |
|
Still I see |
…olve linter errors
…uth0#1348) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: snyk-bot <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
91e571c to
e80be9e
Compare
|
Man Im sorry Im stuck verifying my commit I think Ill recreate a PR soon with the commit signing enabled ASAP |
Changes
Summary of changes:
Added two new public constants:
WebAuthErrorCodesCredentialsManagerErrorCodesAdded a combined constant
AuthErrorCodesthat merges both sets of codes.Added a corresponding union type
AuthErrorCodefor all possible errortypevalues across the SDK.Updated
ERROR_CODE_MAPinWebAuthErrorandCredentialsManagerErrorto reference the new constants instead of hardcoded strings.Why this is important:
WebAuthErrorCodes.<CODE>,CredentialsManagerErrorCodes.<CODE>,AuthErrorCodes.<CODE>).Classes and methods changed:
WebAuthError: no behavioral change, internalERROR_CODE_MAPnow uses constants.CredentialsManagerError: same as above.AuthError: new exports added (AuthErrorCodes,AuthErrorCode).No endpoints or UI are affected by this change.
References
Testing
How reviewers can test:
Run the existing unit test suite — no tests should fail.
Verify that
WebAuthErrorandCredentialsManagerErrorstill behave as expected (types and mappings).Import and use the new constants in a test or sample app:
Confirm TypeScript autocompletion works for:
WebAuthErrorCodes.<CODE>CredentialsManagerErrorCodes.<CODE>AuthErrorCodes.<CODE>Testing notes:
No new runtime behavior introduced.
This change affects type definitions and internal mappings only.
No new dependencies or API calls added.
This change adds unit test coverage (optional enhancement for type-based validation can be added later).
This change has been tested locally on the latest React Native SDK setup.
Checklist