Skip to content

Conversation

andreujuanc
Copy link

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

moved the types from dependencies, to devdependencies.

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@andreujuanc andreujuanc requested a review from a team as a code owner October 2, 2024 23:58
@andreujuanc
Copy link
Author

Found this who added it #314

@andreujuanc
Copy link
Author

First time was added 6fc054d
PR: #9
Real bad excuse to have it moved. Consumers of this library SHOULD NOT compile it, but instead, it should come pre-bundled.

@andreujuanc
Copy link
Author

BTW if the problem is that this library is exposing dependencies' types, those can be added as peerDependencies.

@NeoDobby
Copy link

NeoDobby commented Mar 3, 2025

Additionally to moving the types to devDependencies, it would make sense to have anything that is required or imported in the code in dependencies or peerDependencies.

@Sealos
Copy link

Sealos commented May 13, 2025

Could this be looked into? This repository is included in firebase-admin, and it's installing more dependencies than it should in production builds.
@adamjmcgrath @nandan-bhat

Thanks in advance.

@IschanLois
Copy link

Hey, any updates on this? Because with @types/[email protected], there is an issue with typescript esm projects without esModuleInterop. @types/[email protected] relies on ms which is using commonjs. I know that this is easily addressable with changing ts configs, but allowing extra flexibility would be great 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants