chore(windows): remove deprecated cpprestsdk dependency#906
Draft
NandanPrabhu wants to merge 1 commit into
Draft
chore(windows): remove deprecated cpprestsdk dependency#906NandanPrabhu wants to merge 1 commit into
NandanPrabhu wants to merge 1 commit into
Conversation
Replaces cpprestsdk (Microsoft's archived "Casablanca" C++ REST SDK) with maintained alternatives: cpp-httplib for HTTP (production token exchange / JWKS fetch, and the test-only mock JWKS server), and nlohmann::json for JSON, across the Windows plugin. Also replaces pplx::task/cancellation_token with Microsoft PPL (<ppltasks.h>, built into the MSVC toolset) in oauth_helpers and the login/logout request handlers. boost-system/boost-date-time/boost-regex are dropped too, since they were only ever transitive requirements of cpprestsdk's own CMake package config and were never used directly anywhere in the plugin. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
boost-system,boost-date-time,boost-regex) that were never used directly.cpp-httplib, JSON handling withnlohmann::json, and async/cancellation (pplx::) with Microsoft PPL (<ppltasks.h>/concurrency::), which ships with the MSVC toolset and needs no extra vcpkg dependency.vcpkg.json,CMakeLists.txt, and the CI workflow's explicitvcpkg installstep to reflect the new dependency set.Test plan
cpprest/pplx/boostreferences outside of a few explanatory comments contrasting old vs. new behaviorThrowsWhenJwksEndpointIsUnreachable,ThrowsOnHttp5xxResponse, etc.)httplib::Clientusage🤖 Generated with Claude Code