Skip to content

fix: treat nil enabled_clients as enabled for all applications #1532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidlovas wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −3
Open

fix: treat nil enabled_clients as enabled for all applications #1532

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions internal/cli/users.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,10 @@ func createUserCmd(cli *cli) *cobra.Command {
return fmt.Errorf("failed to find connection with name %q: %w", inputs.connectionName, err)
}

if len(connection.GetEnabledClients()) == 0 {
// A nil slice means enabled_clients was null in the API response,
// which means the connection is enabled for all applications.
// Only reject if explicitly set to an empty slice (disabled for all).
if enabledClients := connection.GetEnabledClients(); enabledClients != nil && len(enabledClients) == 0 {
return fmt.Errorf(
"failed to continue due to the connection with name %q being disabled, enable an application on this connection and try again",
inputs.connectionName,
Expand Down Expand Up @@ -894,7 +897,10 @@ The file size limit for a bulk import is 500KB. You will need to start multiple
return fmt.Errorf("failed to read connection with name %q: %w", inputs.ConnectionName, err)
}

if len(connection.GetEnabledClients()) == 0 {
// A nil slice means enabled_clients was null in the API response,
// which means the connection is enabled for all applications.
// Only reject if explicitly set to an empty slice (disabled for all).
if enabledClients := connection.GetEnabledClients(); enabledClients != nil && len(enabledClients) == 0 {
return fmt.Errorf(
"failed to continue due to the connection with name %q being disabled, enable an application on this connection and try again",
inputs.ConnectionName,
Expand Down Expand Up @@ -996,7 +1002,10 @@ func (c *cli) databaseAndPasswordlessConnectionOptions(ctx context.Context) ([]s

var connectionNames []string
for _, connection := range connectionList.Connections {
if len(connection.GetEnabledClients()) == 0 {
// A nil slice means enabled_clients was null in the API response,
// which means the connection is enabled for all applications.
// Only skip if explicitly set to an empty slice (disabled for all).
if enabledClients := connection.GetEnabledClients(); enabledClients != nil && len(enabledClients) == 0 {
continue
}

Expand Down