OP_APPLY_LAST: fix stacktrace on failure #1758
Merged
+18
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pguyot
force-pushed
the
w29/fix-apply-last-stacktrace
branch
from
78257dd to
0663af4
Compare
bettio
approved these changes
Jul 15, 2025
pguyot
force-pushed
the
w29/fix-apply-last-stacktrace
branch
2 times, most recently
from
fe67faf to
536cc3c
Compare
|
The issue was related to |
Truncate stack only after checking module and function, thus generating a more helpful stacktrace, following what BEAM does. Signed-off-by: Paul Guyot <[email protected]>
pguyot
force-pushed
the
w29/fix-apply-last-stacktrace
branch
from
536cc3c to
2b95eb4
Compare
bettio
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Truncate stack only after checking module and function, thus generating a more helpful stacktrace, following what BEAM does.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later