Add support for node@12

[yvele]

Requirements for Contributing a Bug Fix

• Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
• The pull request must only fix an existing bug. To contribute other changes, you must use a different template. You can see all templates at https://github.com/atom/.github/tree/master/.github/PULL_REQUEST_TEMPLATE.
• The pull request must update the test suite to demonstrate the changed functionality. For guidance, please see https://flight-manual.atom.io/hacking-atom/sections/writing-specs/.
• After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see https://github.com/atom/.github/tree/master/CONTRIBUTING.md#pull-requests.

Identify the Bug

Fixes #10

Description of the Change

This pull request adds supports for Node.js v12 by briging those 2 commits:

• Axosoft@462dfb8
• Axosoft@9cf41b8

Alternate Designs

Not needed

Possible Drawbacks

I'm not into C++ but as @rsese said, it should be easy to implement 🤔 (edit by @rsese: as mentioned in #11 (comment), wasn't trying to say this update was easy 😄)

Verification Process

Added Node.js V12 in the unit test matrix

Release Notes

Add support for Node.js v12

[rsese]

Thanks for the contribution @yvele! Before it can be reviewed, can you please update the pull request body to use our pull request template? I think it may not have shown for you because this is a fork.

[yvele]

@rsese ok done

[rsese]

Thanks @yvele - we can't promise a timeline for when this will get reviewed but if there are any questions about your changes, whoever reviews it will follow up.