Skip to content

Conversation

aminya
Copy link
Member

@aminya aminya commented Jun 26, 2022

@aminya aminya marked this pull request as draft June 26, 2022 03:21
Copy link
Member Author

@aminya aminya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failure is due to tree-sitter. Not sure why pnpm is also installing those for only installing papm

https://dev.azure.com/atomcommunity/atomcommunity/_build/results?buildId=1268&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=cccdf131-0893-5d7b-ccea-9ccfc8953f95&l=2009

.../node_modules/tree-sitter install: make: Entering directory '/home/vsts/work/1/s/node_modules/.pnpm/github.com+DeeDeeG+node-tree-sitter@bb298eaae66e0c_633c9cfccc090bdf5cdf71b8c45226ac/node_modules/tree-sitter/build'
.../node_modules/tree-sitter install: make: *** No rule to make target 'Release/obj.target/tree_sitter/vendor/tree-sitter/lib/src/lib.o', needed by 'Release/obj.target/tree_sitter.a'.  Stop.
.../node_modules/tree-sitter install: make: Leaving directory '/home/vsts/work/1/s/node_modules/.pnpm/github.com+DeeDeeG+node-tree-sitter@bb298eaae66e0c_633c9cfccc090bdf5cdf71b8c45226ac/node_modules/tree-sitter/build'
.../node_modules/tree-sitter install: gyp ERR! build error 
.../node_modules/tree-sitter install: gyp ERR! stack Error: `make` failed with exit code: 2
.../node_modules/tree-sitter install: gyp ERR! stack     at ChildProcess.onExit (/opt/hostedtoolcache/node/12.18.3/x64/lib/node_modules/pnpm/dist/node_modules/node-gyp/lib/build.js:194:23)
.../node_modules/tree-sitter install: gyp ERR! stack     at ChildProcess.emit (events.js:315:20)
.../node_modules/tree-sitter install: gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:275:12)
.../node_modules/tree-sitter install: gyp ERR! System Linux 5.4.0-1085-azure
.../node_modules/tree-sitter install: gyp ERR! command "/opt/hostedtoolcache/node/12.18.3/x64/bin/node" "/opt/hostedtoolcache/node/12.18.3/x64/lib/node_modules/pnpm/dist/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
.../node_modules/tree-sitter install: gyp ERR! cwd /home/vsts/work/1/s/node_modules/.pnpm/github.com+DeeDeeG+node-tree-sitter@bb298eaae66e0c_633c9cfccc090bdf5cdf71b8c45226ac/node_modules/tree-sitter
.../node_modules/tree-sitter install: gyp ERR! node -v v12.18.3
.../node_modules/tree-sitter install: gyp ERR! node-gyp -v v8.4.1
.../node_modules/tree-sitter install: gyp ERR! not ok 
.../node_modules/tree-sitter install: Failed

@aminya
Copy link
Member Author

aminya commented Jun 26, 2022

Oh, OK. It was because of pnpm-workspace.yaml. It treated the whole thing as a workspace.

@DeeDeeG
Copy link
Member

DeeDeeG commented Jun 26, 2022

I think pnpm does not install git submodules when fetching packages specified as git URLs. That's why it's having trouble installing tree-sitter.

pnpm/pnpm#3801

@aminya
Copy link
Member Author

aminya commented Jun 30, 2022

Requested a release
tree-sitter/node-tree-sitter#111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants