Skip to content

fix: set workspaceFolders to null when there is no workspace #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2020
Merged

fix: set workspaceFolders to null when there is no workspace #106

merged 1 commit into from
Dec 12, 2020

Conversation

aminya
Copy link
Member

@aminya aminya commented Dec 12, 2020 •
edited
Loading

Based on https://microsoft.github.io/language-server-protocol/specifications/specification-current/#initialize

	/**
	 * The workspace folders configured in the client when the server starts.
	 * This property is only available if the client supports workspace folders.
	 * It can be `null` if the client supports workspace folders but none are
	 * configured.
	 *
	 * @since 3.6.0
	 */
	workspaceFolders?: WorkspaceFolder[] | null;

vuejs/vetur#2561 (comment)

@aminya aminya added the bug Something isn't working label Dec 12, 2020
@aminya aminya force-pushed the null-when-no-workspace branch from 41c87ae to 5814197 Compare December 12, 2020 08:13
UziTech
UziTech approved these changes Dec 12, 2020
View reviewed changes
Copy link
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@UziTech UziTech merged commit f738100 into master Dec 12, 2020
@UziTech UziTech deleted the null-when-no-workspace branch December 12, 2020 19:03
@github-actions
Copy link

🎉 This PR is included in version 1.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UziTech UziTech UziTech approved these changes

Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aminya @UziTech