Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JPERF-1409 Add MultiJfrFilter #106

Merged
merged 1 commit into from
Dec 13, 2023
Merged

JPERF-1409 Add MultiJfrFilter #106

merged 1 commit into from
Dec 13, 2023

Conversation

mgrzaslewicz
Copy link
Contributor

No description provided.

@mgrzaslewicz mgrzaslewicz requested a review from a team as a code owner December 13, 2023 11:05
dagguh
dagguh approved these changes Dec 13, 2023
View reviewed changes
src/test/kotlin/com/atlassian/performance/tools/report/jfr/MultiJfrFilterTest.kt
// then
assertThat(multiDuration)
.describedAs("Multi duration should be at least 60% faster than single - given enough outputs to produce")
.isLessThan((singleDuration * 0.4).toLong())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test!

@mgrzaslewicz mgrzaslewicz merged commit 28ef2c4 into master Dec 13, 2023
2 checks passed
@mgrzaslewicz mgrzaslewicz deleted the issue/jperf-1409-multi-jfr-filter branch December 13, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagguh dagguh dagguh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgrzaslewicz @dagguh