Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARC-2723 add share modal #219

Conversation

rachellerathbone
Copy link
Collaborator

What's in this PR?
Added onClick event to open a modal for the share page button.

Why
So Jira admins can share a link to the global page with their Jenkins admin.

In the following recording:

  • I click the share page button which opens the modal
  • I click copy to clipboard and see a confirmation
  • I copy the contents to a Confluence page (demo purposes)
  • I show that there are 2 people with access to the jira site: admin Rachelle and non-admin Rachelle 🙃
  • Non Jira admin Rachelle pastes the link and is able to view the global page (this will only work in dev atm coz it's deployed there... maybe stg too, I can't remember 🤷 )
Screen.Recording.2023-12-11.at.7.43.41.pm.mov

Added feature flags
always the same

Affected issues
ARC-2729

How has this been tested?
Locally and unit tests

What's Next?
Merge many many PRs so @joshkay10 doesn't have to wrap up all my work next week? 🤔

@rachellerathbone rachellerathbone changed the title ARC-2729 add share modal ARC-2737 add share modal Dec 11, 2023
@rachellerathbone rachellerathbone changed the title ARC-2737 add share modal ARC-2723 add share modal Dec 11, 2023
@rachellerathbone
Copy link
Collaborator Author

Wrong issue key in branch name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant