Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AXON-193: make customJqlTreeView only visible when user has custom JQLs + fix bug + add util tests #194

Merged
merged 7 commits into from
Mar 13, 2025
Merged

AXON-193: make customJqlTreeView only visible when user has custom JQLs + fix bug + add util tests #194

merged 7 commits into from
Mar 13, 2025

Conversation

cabella-dot
Copy link
Contributor

@cabella-dot cabella-dot commented Mar 13, 2025 •
edited
Loading

What Is This Change?

  • Made customJqlTreeView to only be visible when user has custom JQLs enabled
  • Made assignedToMeTreeView and customJqlTreeview only visible when Jira Explorer is enabled
  • fixed bug where assigning yourself in Issue view does not refresh the tree
  • Add util tests for new JiraIssueNode for coverage on statusCategory tag assignment
  • added relevant commands to AssignedToMeView

Loom:
https://www.loom.com/share/7b1f04900c164c08a83e2d7dd8ac85d7?sid=1546e877-1257-4ac0-a3f2-4a0c29ad4e8d

How Has This Been Tested?

Unit testing + Manual testing

Basic checks:

  • npm run lint
  • npm run test

@marcomura
Copy link
Contributor

Thanks for adding the icons like 'create new issue', 'search', the 3-dots menu, etc!
And for fixing the missing refresh when editing a jira issue in tab :)

marcomura
marcomura approved these changes Mar 13, 2025
View reviewed changes
Copy link
Contributor

@marcomura marcomura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!! thanks!

@cabella-dot cabella-dot merged commit 055c7dd into main Mar 13, 2025
2 checks passed
@cabella-dot cabella-dot deleted the AXON-193-add-logic-so-custom-jql-filters-sidebar-only-appea branch March 13, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcomura marcomura marcomura approved these changes

@bwieger-atlassian-com bwieger-atlassian-com Awaiting requested review from bwieger-atlassian-com bwieger-atlassian-com is a code owner

@sdzh-atlassian sdzh-atlassian Awaiting requested review from sdzh-atlassian sdzh-atlassian is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cabella-dot @marcomura