-
Notifications
You must be signed in to change notification settings - Fork 1.2k
added update event listener #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
bound a listener for an `update` event which calls the `val` method with the second param as `false` so as not to trigger the release handler. this is useful when we create a knob that we update periodically as well expect the user to interact with at the same time e.g. an audio scrubber which shows the track progress which you can change as well.
This is great, I'm going to test it soon. I use jQuery Knob in the same case you described in RuneAudio UI (www.runeaudio.com), and we had to apply a dirty hack to make it work as expected. I hope this solves the problem, thank you! |
added a `scrubbing` flag which prevents the `val` function from overwriting the `cv` variable when the user is scrubbing, this stops a flickering issue when the user is scrubbing but the `val` get's updated in the processes temporarily when the `cv` value gets overwritten.
added triggering of change handler when using mouse wheel to change values
@HaykoKoryun, from the perspective of the dial, can you rename the "scrubbing" property to "isChanging" (or something better:)) ? can you give us a use case of the "scrubbing" flag ? |
@aterrien in audio players the bar that controls the playhead is commonly called a scrubber: http://en.wikipedia.org/wiki/Scrubbing_(audio) although I have to admit that this is not the only use case for the dial so the term might not be 100% appropriate; I was working on an audio project recently so that was the most decent name I could come up with. I didn't want to name it |
@HaykoKoryun I'm very interested in implementing your mod in our setup and see if it can solve some issues we are experiencing. Could I ask you a couple of questions about it? If yes, please write me at [email protected]. |
forgot to add a crucial part for the scrubbing flag to work 😞 |
bound a listener for an
update
event which calls theval
method with the second param asfalse
so as not to trigger the release handler.this is useful when we create a knob that we update periodically as well as expect the user to interact with at the same time e.g. an audio scrubber which shows the track progress which you can change as well.