1.4.0

[kwibus]

TODO

• Still need change console-title Your Lab is being deployed . could be better message. or be configurable
• icon idle warning looks at wrong location
• logic src/main/resources/controllers/hostController.js is buggy. Hopes this can be done in more reliable and simpler
• [-] pass more parameters to START_COMMAND / STOP_COMMAND and document this
• update documentation

[jandusek]

This is working quite nicely. I agree that having a configurable console-title would be great.

[adb014]

I'd really like to see this pull request closed so my build doesn't depend on unreleased code. I'd be willing to put in the work on the issues that are unresolved to close this in th e TODO list. Though I have a question about making console-title configurable. I see two ways of doing this

1. Assume that all of the user configuration for the trigger module must follow the same behaviour, and so console-title of trigger-console-title should be added to guacamole.properties and if enable-environment-properties is set an equivalent environement variable on the guacamole instance used. This would means the angular front-end must use a REST endpoint to the guacamole server to get the console-title to use, so it would be more work, but ok
2. add console-title to the guac-manifest.json file used by the trigger module and use it. This would be easy, but the downside is the user wanting the change the title would need to rebuild the WAR file

How did you see this variable being made configurable ?

[adb014]

Ok, I've added configurable console titles via guacamole.properties in my fork at https://github.com/adb014/guacamole-trigger. Two slight issues

• The variable $hostname is allowed in the string and will be replace in the backend by the real hostname
• The encoding of the console-title needs to be the same as used in JAVA_OPTS and CATALINE_OPTS in "-Dfile.encoding=...". If this is absent java seems to assume ISO-8859-1 rather the UTF-8 and so accented character might be misinterpreted

I'll try the up date the document so that this pull request can be closed

[adb014]

I've now also updated the Readme.md file. However, I haven't replace the screenshot I I think you might prefer something else that what I might supply