Skip to content

Fix intuitive propagation behavior #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix intuitive propagation behavior #52

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
78fbb25
Fix intuitive propagation behavior
zach-capalbo Jul 18, 2019
1a85be6
Fix mouse leaving window while dragging
zach-capalbo Jul 18, 2019
903b97f
A little bit cleaner mouse out of window logic
zach-capalbo Jul 18, 2019
2badd4a
Mouse Enter Typo
zach-capalbo Jul 19, 2019
0594487
Fix overzealous click prevention
zach-capalbo Jul 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 30 additions & 6 deletions dragscroll.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,25 +21,30 @@
var mousemove = 'mousemove';
var mouseup = 'mouseup';
var mousedown = 'mousedown';
var mouseenter = 'mouseenter';
var click = 'click';
var EventListener = 'EventListener';
var addEventListener = 'add'+EventListener;
var removeEventListener = 'remove'+EventListener;
var newScrollX, newScrollY;
var moveThreshold = 4;

var dragged = [];
var reset = function(i, el) {
for (i = 0; i < dragged.length;) {
el = dragged[i++];
el = el.container || el;
el[removeEventListener](mousedown, el.md, 0);
el[removeEventListener](click, el.mc, 0);
_window[removeEventListener](mouseup, el.mu, 0);
_window[removeEventListener](mousemove, el.mm, 0);
_document[removeEventListener](mouseenter, el.me, 0);
}

// cloning into array since HTMLCollection is updated dynamically
dragged = [].slice.call(_document.getElementsByClassName('dragscroll'));
for (i = 0; i < dragged.length;) {
(function(el, lastClientX, lastClientY, pushed, scroller, cont){
(function(el, lastClientX, lastClientY, startX, startY, moved, pushed, scroller, cont){
(cont = el.container || el)[addEventListener](
mousedown,
cont.md = function(e) {
Expand All @@ -49,22 +54,40 @@
) == cont
) {
pushed = 1;
lastClientX = e.clientX;
lastClientY = e.clientY;

moved = 0;
startX = lastClientX = e.clientX;
startY = lastClientY = e.clientY;
e.preventDefault();
e.stopPropagation();
}
}, 0
);

(cont = el.container || el)[addEventListener](
click,
cont.mc = function(e) {
if (moved) {
e.preventDefault();
e.stopPropagation();
moved = 0; pushed = 0;
}
}, 1
);
_window[addEventListener](
mouseup, cont.mu = function() {pushed = 0;}, 0
);

_document[addEventListener](
mouseenter, cont.me = function(e) {if (!e.buttonsPressed) pushed = 0;}, 0
);
_window[addEventListener](
mousemove,
cont.mm = function(e) {
if (pushed) {
if (!moved &&
(Math.abs(e.clientX - startX) > moveThreshold ||
Math.abs(e.clientY - startY) > moveThreshold)) {
moved = true;
}
if (moved) {
(scroller = el.scroller||el).scrollLeft -=
newScrollX = (- lastClientX + (lastClientX=e.clientX));
scroller.scrollTop -=
Expand All @@ -73,6 +96,7 @@
(scroller = _document.documentElement).scrollLeft -= newScrollX;
scroller.scrollTop -= newScrollY;
}
}
}
}, 0
);
Expand Down