-
-
Notifications
You must be signed in to change notification settings - Fork 424
ESA Euclid EUCLIDSWRQ-215 get_datalinks_metadata #3438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jsaizsantos
wants to merge
10
commits into
astropy:main
Choose a base branch
from
esdc-esac-esa-int:ESA_euclid-EUCLIDSWRQ-215-get_datalinks_metadata
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+90
−13
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
9bbea59
EUCLIDSWRQ-215: Add get_datalinks_metadata & options to get_datalinks
jsaizsantos 91ea007
EUCLIDSWRQ-215: Add test_get_datalinks_metadata
jsaizsantos e11f753
EUCLIDSWRQ-215: Correct assertion
jsaizsantos fa21e76
EUCLIDSWRQ-215: Add documentation for get_datalinks_metadata
jsaizsantos 671956f
Change for PR #3438 added to CHANGES.rst
jsaizsantos 06c897d
EUCLIDSWRQ-215: Rename options to extra_options and update changelog
jsaizsantos b103634
Merge branch 'main' into ESA_euclid-EUCLIDSWRQ-215-get_datalinks_meta…
jsaizsantos a2fb3a1
EUCLIDSWRQ-215: Correct blank lines
jsaizsantos 0638e44
EUCLIDSWRQ-215: Correct usage of extra_options in TapPlus class
jsaizsantos 8c8dc07
EUCLIDSWRQ-215: Break line too long
jsaizsantos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why have this as a separate method rather than just documenting the one needs to have use
options='METADATA'? The narrative documentation example below throw me off the track as starting with that one, and based on the method name I expected only metadata rather than it having the same result as usingget_datalinksand some extra metadata.