Skip to content

Addresses Issue #3138 - ESO - Enable Table Access Protocol (TAP) queries #3339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

juanmcloaiza
Copy link
Contributor

Addresses #3138

Changes:

Switch querying interface from WDB to TAP in querying functions:

  • query_main
  • query_instruments
  • query_surveys
  • query_apex_quicklooks
  • list_instruments
  • list_surveys

Deprecate arguments:

  • open_form
  • cache

New functionality:

  • Allow plain ADQL queries via query_tap_service (with authentication as well)
  • Cone search using cone_ra, cone_dec, cone_radius arguments
  • Retrieve record count before querying the archive, via count_only argument
  • Ask query functions to print the underlying ADQL queries without issuing them

@juanmcloaiza juanmcloaiza force-pushed the feature/ISSUE-3138-TAP branch from 720fbd9 to 22d0c30 Compare June 5, 2025 12:55
Copy link

codecov bot commented Jun 5, 2025

Codecov Report

❌ Patch coverage is 82.80702% with 49 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.69%. Comparing base (d140a90) to head (4b775f8).
⚠️ Report is 43 commits behind head on main.

Files with missing lines Patch % Lines
astroquery/eso/core.py 75.40% 45 Missing ⚠️
astroquery/eso/utils.py 96.03% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3339      +/-   ##
==========================================
+ Coverage   70.07%   70.69%   +0.61%     
==========================================
  Files         232      233       +1     
  Lines       19884    19841      -43     
==========================================
+ Hits        13934    14026      +92     
+ Misses       5950     5815     -135     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@juanmcloaiza juanmcloaiza force-pushed the feature/ISSUE-3138-TAP branch 2 times, most recently from 76675d2 to c32f348 Compare June 5, 2025 13:18
@juanmcloaiza juanmcloaiza force-pushed the feature/ISSUE-3138-TAP branch from a987745 to 4b775f8 Compare June 5, 2025 13:49
@juanmcloaiza juanmcloaiza mentioned this pull request Jun 5, 2025
8 tasks
@juanmcloaiza
Copy link
Contributor Author

Hi @bsipocz , could you please give us a time estimate of the review process? No pressure at all though, we only need to plan our activities internally. Thanks a lot in advance.

@bsipocz
Copy link
Member

bsipocz commented Jul 21, 2025

@juanmcloaiza - sorry for the delay. I'll try to get to the review this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants