-
-
Notifications
You must be signed in to change notification settings - Fork 419
Addresses Issue #3138 - ESO - Enable Table Access Protocol (TAP) queries #3339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
720fbd9
to
22d0c30
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3339 +/- ##
==========================================
+ Coverage 70.07% 70.69% +0.61%
==========================================
Files 232 233 +1
Lines 19884 19841 -43
==========================================
+ Hits 13934 14026 +92
+ Misses 5950 5815 -135 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
76675d2
to
c32f348
Compare
a987745
to
4b775f8
Compare
Hi @bsipocz , could you please give us a time estimate of the review process? No pressure at all though, we only need to plan our activities internally. Thanks a lot in advance. |
@juanmcloaiza - sorry for the delay. I'll try to get to the review this week. |
Addresses #3138
Changes:
Switch querying interface from WDB to TAP in querying functions:
Deprecate arguments:
open_form
cache
New functionality:
query_tap_service
(with authentication as well)cone_ra
,cone_dec
,cone_radius
argumentscount_only
argument