feat: Add microvm.credentialFiles
for passing credentials to guests
#337
+18
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements
microvm.credentialFiles
a mechanism for passingcredentials into guest vms from the host.
Currently only support for qemu is implemented as I want to test the waters to
see if you're interested in this feature, Astro.
In addition to qmeu, cloud-hypervisor can be supported via smbios. But it depends
on this feature being added, and also #336 being merged to microvm.nix
cloud-hypervisor could be supported immediately, but then the secrets would be
visible in the ps output.
A cursory code search shows that the following additional hypervisors could be
supported:
kvmtool and firecracker both seem like they cannot be supported.
Related: