Skip to content

On-the-fly support for Fourier Wigner transforms with Risbo recursions #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 23, 2025

Conversation

CosmoMatt
Copy link
Collaborator

Updates the Fourier Wigner transforms to add support for the case in which no precomputes are provided. In this case the appropriate values for the Wigner Fourier coefficients (and quadrature weights for the forward transform) are computed on-the-fly.

@CosmoMatt CosmoMatt added enhancement New feature or request clean up labels Jan 21, 2025
@CosmoMatt CosmoMatt requested a review from jasonmcewen January 21, 2025 09:46
@CosmoMatt CosmoMatt self-assigned this Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.33%. Comparing base (351fc94) to head (17d5d37).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
+ Coverage   96.29%   96.33%   +0.04%     
==========================================
  Files          31       31              
  Lines        3586     3627      +41     
==========================================
+ Hits         3453     3494      +41     
  Misses        133      133              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jasonmcewen
Copy link
Contributor

jasonmcewen commented Mar 19, 2025

To clarify, this uses Risbo recursion.

We discussed refactoring this so Risbo is supported for (spin) spherical harmonic transforms as well as Wigner transforms. However, it is probably better to consider that in a separate PR, so let's go ahead and merge this. I'll do a final review shortly and then we can merge.

@jasonmcewen jasonmcewen changed the title add on-the-fly support for Fourier Wigner transforms On-the-fly support for Fourier Wigner transforms with Risbo recursions Mar 19, 2025
* Variable name and type hint cleanup

* Refactor to remove repeated code
@matt-graham
Copy link
Collaborator

Tests on Python 3.10+ failing due to #299 - once #300 is merged we should merge in changes from main here and rerun.

@matt-graham matt-graham merged commit 3f1a2d0 into main Apr 23, 2025
15 checks passed
@matt-graham matt-graham deleted the map/recursive_risbo_otf branch April 23, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean up enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants