Run cargo fmt and cargo clippy --fix
#781
Open
+66
−99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is from cargo 1.88, since 1.89 pulls in let-chains, and whatever version of Rust is in GitHub CI doesn't support them last time I tried. (We should upgrade it at some point, though, since our Rust usage is all internal.)
geofft
commented
Aug 31, 2025
| @@ -628,7 +628,7 @@ static LLVM_URL: Lazy<Url> = Lazy::new(|| { | |||
| /// Returns the path to the top-level `llvm` directory. | |||
| pub async fn bootstrap_llvm() -> Result<PathBuf> { | |||
| let url = &*LLVM_URL; | |||
| let filename = url.path_segments().unwrap().last().unwrap(); | |||
| let filename = url.path_segments().unwrap().next_back().unwrap(); | |||
There was a problem hiding this comment.
"warning: called Iterator::last on a DoubleEndedIterator; this will needlessly iterate the entire iterator"
https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is from cargo 1.88, since 1.89 pulls in let-chains, and whatever version of Rust is in GitHub CI doesn't support them last time I tried. (We should upgrade it at some point, though, since our Rust usage is all internal.)