Skip to content

Use gh release instead of someone's release action #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025

Conversation

geofft
Copy link
Collaborator

@geofft geofft commented May 30, 2025

The upstream action times out because it requests every release (without pagination), and there's no real need to use a third-party action for this when the gh command does a perfectly fine job too.

The upstream action times out because it requests every release (without
pagination), and there's no real need to use a third-party action for this when
the `gh` command does a perfectly fine job too.
@geofft geofft requested review from Gankra and zanieb May 30, 2025 21:31
@geofft geofft added the ci:skip label May 30, 2025
Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I hate Actions!

@geofft
Copy link
Collaborator Author

geofft commented May 30, 2025

Meant to send this earlier - I am pretty sure this matches the behavior of the third-party action as we were using it. (I don't know whether we actually want the behavior of reusing a previous prerelease... given that you have to manually delete the tag anyway, it doesn't really make anything easier, and I kind of don't want assets uploaded that the most recent run wouldn't have uploaded.)

I am not totally sure how to test this. I could some releases with 1980s version numbers and see what happens? I could make a detached fork in my account and try it out? Alternatively I'll likely do the next release and I can just make sure it does what I expect, if we're comfortable merging without testing.

@zanieb
Copy link
Member

zanieb commented Jun 2, 2025

I'm fine with moving forward without testing for now.

@zanieb zanieb merged commit 8f3c1d1 into astral-sh:main Jun 4, 2025
4 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants