Skip to content

Align tox lint with the pinned pre-commit Ruff version - #469

Open
xiehuanyi wants to merge 1 commit into
astanin:masterfrom
xiehuanyi:fix-pin-ruff-ci
Open

xiehuanyi wants to merge 1 commit into
astanin:masterfrom
xiehuanyi:fix-pin-ruff-ci

Conversation

@xiehuanyi

Copy link
Copy Markdown

The pre-commit hooks use Ruff0.15.4, while the tox lint environment installs an unconstrained Ruff version. A fresh tox run -e lint --recreate on unchanged master currently selects Ruff0.17.0 and fails with269 diagnostics, even though the repository-pinned pre-commit version accepts the same source.

Pin the tox lint dependency to the existing pre-commit version so both entry points run the same checks. Future Ruff upgrades can update both definitions together.

Validation on Python3.12: fresh unchanged-base tox lint fails; after this one-line dependency alignment, fresh tox lint passes both ruff check and ruff format --check (13 files). No source/style changes are included. The separate openPR454 upgrades pre-commit and source styling; this PR only aligns tox with the current committed version.

Prepared with AI assistance.

Copilot AI balanced review requested due to automatic review settings October 10, 2026 18:02

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants